Child pages
  • Code Review 04-24-14

Versions Compared


  • This line was added.
  • This line was removed.
  • Formatting was changed.


  • 2014-03-25: Sinisa sent out Review Meeting Notice.
  • 2014-04-17: John tagged the code and sent out additional instructions for running it (tag URL:
  • 2014-04-23: Each reviewer prepared their own list of issues for the Review Meeting.
  • 2014-04-24: Review Meeting was held @ 10:00am (C2200). Arthur prepared meeting notes.
  • 2014-04-25: Sinisa prepared review report outlining issues that may have to be addressed.
  • 2014-0504-??29: Followup Meeting John Hammonds and Nicholas Schwarz.


  1. File Tab: Cancel button calls uninitialized variable if pressed before loading.
  2. File Tab: Entering wrong number of arguments into "Detector ROI" or "Number of Pixels To Average" results with a generic "list index out of range" exception, rather than with a specific error message.
  3. File Tab: Supplying wrong xml file for Detector config results with a "NoneType object has no attribute findall" error, rather than with a specific error message.
  4. File Tab: User's choice for input project file is not limited via filters.
  5. File Tab: GUI components are not disabled while loading configuration/data files.
  6. File Tab: Loading incorrect xml file does not display error / warning message.
  7. File Tab: "Cancel" button is always enabled, even if there is nothing that can be canceled.
  8. File Tab: Loading spec files copied to a different location without underlying images does not indicate any errors, even though application will not work.
  9. File Tab: There is no application feedback ("working...", "done") on the state of progress through the load operation.
  10. File Tab: GUI does not permit both Bad Pixel File and Flat Field Correction, even though underlying code allows it.
  11. Process Data Tab: User is not notified about where processing output is being stored.
  12. Data Range Tab: Supplying min argument that is greater than max argument does not display error message.
  13. Data Range Tab: Reset button is always enabled, and does not seem to be doing anything other than converting integer to float.
  14. Scans Tab: Column values for theta, chi, etc, can be changed to strings.
  15. Scans Tab:  Numbers ("X min", etc.) appear editable, but they are not.

  16. Process Data Tab: Processing cannot be cancelled.
  17. Image Window: It is not connected to the main window. If closed, it cannot be brought back.
  18. Image Window: Mouse action is unintuitive, with no obvious way to recover the initial or default orientation.

  19. If orientation is not found in the input spec file, corresponding variable is not set to None.

  20. and Those two files appear to be the same.